Re: [Bug-wget] Send Content-Length with POST 0 length body

[Tim Rühsen]

Am Sonntag, 19. Oktober 2014, 11:27:51 schrieb Matthew Atkinson:
> Hi
> 
> I was looking through the list archives to find something that useful I
> could contribute to wget and get familiar with the code, I have attached
> a patch for the following.
> 
> Darshit Shah <darnir <at> gmail.com> wrote on 2014-09-05 07:31:34 GMT
> 
>  >The Content-Length Header is expected by the server in many requests,
>  >most prominently in a POST Request. However, currently if a POST
>  >request is sent without any body, Wget does not send any
>  >Content-Length headers. Some servers seem to dislike this behaviour
>  >and respond with a 411 Length Required message.
>  >Patch Wget to always send a Content-Length header when the Request
>  >Type is POST.
> 
> Hopefully I can find something less trivial to add or fix in the future,
> any suggestions, direction or feedback, please let me know.

Very good ! Thanks for your work.

There two little things - well, just kinda organizational work:

1. Please also extend src/ChangeLog and include it in your patch
2. The maintainers will ask you for a 'git format-patch' output
  If you never worked with that:
  - git commit your change(s)
  - attach the files generated with 'git format-patch -1'

Thank you

Tim

signature.asc
Description: This is a digitally signed message part.