Re: [Bug-wget] [Win32 Patch] console-close events

[Ángel González]

On 20/10/14 03:03, Darshit Shah wrote:
> On 06/17, Gisle Vanem wrote:
> > "Ángel González" <address@hidden> wrote:
> > > > PS. The above Sleep() seems to be ignored by WinCon. At least I 
> > > > failed to
> > > > make it sleep more than ~500 msec.
> > > There may be a timeout on how long you can stay processing the event.
> > >
> > > Why do you need that Sleep() call at all? I would remove  it.
> >
> > When logging to the console (no '-o log-file' option), the Sleep(500) 
> > will make
> > the final "... cleanup." message stay a tiny bit longer (but barely 
> > readable).
> > Without a Sleep(), the console gets closed with only a message-beep.
>
> Any final reviews / comments on this patch? I haven't tested it out 
> for the lack of a Windows system. If there are no objections, maybe we 
> can push this patch?
I would expect someone running a console application to have a console 
open. I understand the rationale when it's a beginner learning to 
program and is creating a console application, but don't really see a 
usecase for wget. How are you running wget that you get an autoclosing 
console?

Cheers