[Bug-wget] Regression in git master branch (commit 8e6de1fb5ff0ca0c749da7db634a1b1e3a1215a2)

[Gabriel Somlo]

Hi Giuseppe,

I think I found a regression in the development branch of wget, which
wasn't present in 1.15. Using "git bisect", it appears the offending
commit was 8e6de1fb5ff0ca0c749da7db634a1b1e3a1215a2 ("Drop usage of
strncpy") from Jun. 9 2014.

To reproduce, grab a "wide and shallow" copy of wikipedia.org, like so:


  wget -rpkEHN -e robots=off --random-wait -t 2 -U mozilla -l 1 \
       -P ./vservers wikipedia.org


then (some 20 minutes or so later) open ./vservers/wikipedia.org/index.html
in your (firefox-32.0.2-1.fc20.x86_64) browser as a file.

Before commit 8e6de1fb5ff0ca0c749da7db634a1b1e3a1215a2, the page looks
normal. After said commit, it looks (for me) like in the attached
screenshot.

I couldn't revert the commit, as subsequent changes have accumulated
since it was applied. I'm also relatively new to the code base, so
figuring out exactly what went wrong might be significantly faster
for you :)

I can (if necessary) open a ticket in the bug tracker (e.g. for a
better place to upload the screenshot, which may not make it through
on the mailing list), just let me know what you think.

Thanks much,
--Gabriel

borked_wikipedia.png
Description: PNG image