bug-wget
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug-wget] Regression in git master branch (commit 8e6de1fb5ff0ca0c7


From: Giuseppe Scrivano
Subject: Re: [Bug-wget] Regression in git master branch (commit 8e6de1fb5ff0ca0c749da7db634a1b1e3a1215a2)
Date: Wed, 22 Oct 2014 12:11:59 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux)

Ángel González <address@hidden> writes:

> On 21/10/14 09:50, Giuseppe Scrivano wrote:
>> Ángel,
>> thanks for the debugging effort!  Would you mind to send a separate
>> patch that doesn't use strncpy (so to make make dist-check happy),
>> probably we can just use memcpy here.
>>
>> Regards,
>> Giuseppe
> The revert to the old behavior was only intended for checking it was the
> right place. We have xstrndup() to do just what we want. Please test.

in any case this part is wrong as it changes how the function works, and
I think we should fix it anyway.  Good idea to use xstrndup.

Regards,
Giuseppe





reply via email to

[Prev in Thread] Current Thread [Next in Thread]