Re: [Bug-wget] [Bug-Wget] Patch Test-proxied-https-auth.px

[Tim Ruehsen]

On Monday 27 October 2014 12:50:00 Tim Ruehsen wrote:
> On Monday 27 October 2014 12:09:45 Tim Ruehsen wrote:
> > On Monday 27 October 2014 11:51:24 Tim Ruehsen wrote:
> > > On Sunday 26 October 2014 21:29:14 Darshit Shah wrote:
> > > > Ever since the Perl tests have been ported to the parallel test
> > > > harness,
> > > > Test-proxied-https-auth.px has always failed for me. In a prior
> > > > thread,
> > > > we'd identified the problem as a race between the HTTPS server being
> > > > set-up and Wget sending the request.
> > > > 
> > > > The test was already using `sleep 1` to eliminate this race. I've
> > > > bumped
> > > > this up to 2 seconds. Now on my machine, the test no longer fails.
> > > > 
> > > > If everyone is okay with this change, lets push it. If someone wants
> > > > to
> > > > change the number, please speak up.
> > > 
> > > Hi Darshit,
> > > 
> > > I made many test runs in the last time and never ever had
> > > Test-proxied-https-auth.px fail here nor an a second machine (at home).
> > > 
> > > AFAIR, we did not identify a race condition (or let's say a design
> > > flaw).
> > > The test suite starts the server and talks with it before starting Wget.
> > > 
> > > Please append your patch - I would like to further investigate what is
> > > really going wrong (first of all I would like to reproduce the failure).
> > > I
> > > assume the sleep just disguises a deeper problem that may pop up later
> > > in
> > > one or another configuration.
> > 
> > Now i am answering my own mail ;-)
> > 
> > Darshit is right. Test-proxied-https-auth.px brings it's own server code
> > that does not wait / sync parent and child. Thus we have a a design flaw
> > here... which already has been 'fixed' in WgetTests.pm. Just let me take a
> > look if I can transfer some of the code to avoid the race without using
> > sleep.
> > 
> > Or: move Test-proxied-https-auth to the Python test suite !?
> 
> Darshit, could you please test this version of Test-proxied-https-auth.px ?
> 
> It adds a sync between parent and child, so a sleep isn't needed.

I pushed it, since it fixes a bug anyways.

Tim

signature.asc
Description: This is a digitally signed message part.