[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Bug-wget] [PATCH] Fixing several memory leaks
From: |
Giuseppe Scrivano |
Subject: |
Re: [Bug-wget] [PATCH] Fixing several memory leaks |
Date: |
Tue, 28 Oct 2014 13:26:44 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) |
Tim Ruehsen <address@hidden> writes:
> On Thursday 23 October 2014 22:04:55 Tim Rühsen wrote:
>> Am Donnerstag, 9. Oktober 2014, 12:28:05 schrieb Tim Ruehsen:
>> > Hi,
>> >
>> > using the new valgrind testing feature (yet not completely discussed), I
>> > found and fixed several memory leaks.
>> >
>> > Also, I found that parsing the proxy URL did not include the iri (retr.c:
>> > 764). It seemed to me as it just has been forgotten. I added the iri to
>> > url_parse() there. We have no test with an IDN proxy - maybe we should
>> > have
>> > one.
>> >
>> > As I already wrote, 24 perl tests didn't survive valgrind memory testing.
>> > 18 of it will be fixed by this patch.
>> >
>> > 6 others have a problem with libidn (illegal memory access). I'll
>> > investigate this after this email.
>> >
>> > Tim
>>
>> Did you took a look at it ?
>>
>> Shouldn't these fixes go into Wget before the next release ?
>
> May I push these fixes or are there any complaints ?
go for it.
Regards,
Giuseppe