Re: [Bug-wget] [PATCH] Add valgrind testing support via ./configure

[Pär Karlsson]

Regarding the Perl test suite, I'd be happy to clean up the code a little
bit, if you think it's worth it?

There are some minor issues with the current code (such as perl producing
certain warnings regarding invalid operators, i.e: "Argument "" isn't
numeric in numeric eq (==) at WgetTests.pm line 97."), but nothing serious
(and nothing affecting the running of the test suite per se). I'd be happy,
though, to come up with a suggestion for somewhat cleaner but functionally
equivalent code.

/Pär

2014-10-28 12:34 GMT+01:00 Tim Ruehsen <address@hidden>:

> On Monday 27 October 2014 21:59:28 Tim Rühsen wrote:
> > Am Samstag, 25. Oktober 2014, 23:40:41 schrieb Tim Rühsen:
> > > Am Sonntag, 19. Oktober 2014, 17:41:30 schrieb Darshit Shah:
> > > > On 10/09, Tim Rühsen wrote:
> > > > >> Hence, hard coding the command actually reduces the amount of
> work a
> > > > >> user
> > > > >> needs to do in order to run the tests under valgrind.
> > > > >>
> > > > >> My suggestion is that we allow the configure option, but hard code
> > > > >> the
> > > > >> valgrind command into the test suites themselves, and not leave
> them
> > > > >> environment variables.
> > > > >
> > > > >What about removing the configure option and
> > > > >if VALGRIND_TESTS is undefined or empty or "0": normal testing
> > > > >if VALGRIND_TESTS is "1": valgrind testing with hard-coded options
> > > > >else: testing with command given in VALGRIND_TESTS
> > > > >
> > > > >The above described workflow should still work, right ?
> > > > >And we could do the complete test suite with
> > > > >VALGRIND_TESTS="1" make check
> > > > >
> > > > >What do you think ?
> > > >
> > > > --- end quoted text ---
> > > >
> > > > I actually like this idea.
> > > >
> > > > case $VALGRIND_TESTS:
> > > >     "", 0) Normal tests;;
> > > >     1) Hard coded valgrind string;;
> > > >     *) Execute the provided command;;
> > > >
> > > > Could you please make the relevant changes to atleast the Perl based
> > > > tests
> > > > and to configure.ac? I'm currently traveling, but I'll fix the
> Python
> > > > tests
> > > > ASAP and send in a patch which will work well with the aforementioned
> > > > cases.
> > >
> > > Hi Darhsit,
> > >
> > > here is the valgrind patch. Both Perl and Python test suites amended.
> > >
> > Added the ChangeLog entries.
>
> I pushed it.
>
> Tim
>