bug-wget
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug-wget] [PATCH] Add valgrind testing support via ./configure


From: Tim Ruehsen
Subject: Re: [Bug-wget] [PATCH] Add valgrind testing support via ./configure
Date: Wed, 29 Oct 2014 16:05:45 +0100
User-agent: KMail/4.14.2 (Linux/3.16-3-amd64; KDE/4.14.2; x86_64; ; )

On Wednesday 29 October 2014 01:29:47 Pär Karlsson wrote:
> Regarding the Perl test suite, I'd be happy to clean up the code a little
> bit, if you think it's worth it?
> 
> There are some minor issues with the current code (such as perl producing
> certain warnings regarding invalid operators, i.e: "Argument "" isn't
> numeric in numeric eq (==) at WgetTests.pm line 97."), but nothing serious
> (and nothing affecting the running of the test suite per se). I'd be happy,
> though, to come up with a suggestion for somewhat cleaner but functionally
> equivalent code.
> 
> /Pär

Hi Pär,

well cleaner code (=better readable and maintainable) is always welcome.

Due to a lack of Perl experience I introduced the eq/== hickup in one of the 
last commits. I would appreciate it if you also fix it.

In the long term, we want to move all the Perl tests into the Python test 
suite (testenv/). So, please do not spend too much time into the Perl test 
suite. Invest time to move the tests and/or create new tests - e.g. if you can 
reproduce a bug (see Savannah Bug Tracker or the mailing list), create a test 
with it. I think, that really is a good starting point.

Tim

Attachment: signature.asc
Description: This is a digitally signed message part.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]