bug-wget
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Bug-wget] [PATCH] Stylistic and idiomatic cleanups in Perl tests


From: feinorgh
Subject: [Bug-wget] [PATCH] Stylistic and idiomatic cleanups in Perl tests
Date: Thu, 30 Oct 2014 20:54:40 +0100

From: Pär Karlsson <address@hidden>

A number of Perl-specific cleanups in the test suite perl modules.

Most of these changes have no immediate functional difference but puts code
in line with the same formatting (perltidy GNU style) for readability.

A warning regarding invalid operators on incompatible values (numeric vs
strings) have been fixed.

Some common but discouraged Perl idioms have been updated to a somewhat
clearer style, especially regarding evals and map() vs. for loops.

I did not touch the FTP and HTTP server modules functionally, but there seem
to be a lot of strange code there in, and would warrant further cleanups
and investigations if these tests would remain in Perl, instead of moving
over to the Python based tests.

All tests work nominally on my machine (with perl-5.20.1) but should be
compatible with versions down to 5.6.

Pär Karlsson (1):
  Stylistic and idiomatic cleanups in Perl tests

 tests/ChangeLog                  |  12 +
 tests/FTPServer.pm               | 597 +++++++++++++++++++++++----------------
 tests/FTPTest.pm                 |  36 +--
 tests/HTTPServer.pm              | 208 +++++++++-----
 tests/HTTPTest.pm                |  28 +-
 tests/Makefile.am                |   2 +-
 tests/Test-proxied-https-auth.px |   2 +-
 tests/WgetFeature.pm             |  41 ++-
 tests/WgetTest.pm                | 423 +++++++++++++++++++++++++++
 tests/WgetTests.pm               | 334 ----------------------
 10 files changed, 993 insertions(+), 690 deletions(-)
 create mode 100644 tests/WgetTest.pm
 delete mode 100644 tests/WgetTests.pm

-- 
2.0.4




reply via email to

[Prev in Thread] Current Thread [Next in Thread]