Re: [Bug-wget] [PATCH] Stylistic and idiomatic cleanups in Perl tests

[Tim Rühsen]

Am Freitag, 31. Oktober 2014, 18:44:03 schrieb Pär Karlsson:
> Oh, and the test suite works on all stable versions of perl from 5.6
> through 5.20.
> 
> No problems with any of these versions:
> perl-5.6.2
> perl-5.8.9
> perl-5.10.1
> perl-5.12.5
> perl-5.14.4
> perl-5.16.3
> perl-5.18.4
> perl-5.20.1
> 
> And I realize now I probably need some guidance how to format patches
> properly for git format-patch/send-email. Sorry about the spam :-/

Hi Pär,

you don't spam, thanks for your contribution !

And It's very good to know there is a perl expert here !

Well, you cloned wget and maybe worked on the 'master' branch (but I guess, an 
own branch for each task is better in the long term).
After you made your changes and tests, you commit locally with 'git commit -a 
-m "the commit message"'. Now simply 'git format-patch -1' and your complete 
last commit will be saved as a (email) patch file. The filename is 0001-....

Just attach that file to your email.

Now comes the point that people on this list may ask you to amend your 
changes. Do and commit the changes, and merge these two commits into one (git 
rebase -i, I use 'fix' for the commit that should merge into the 'pick' one, 
search the web for detailed description).
On success, you now restart with 'git format-patch -1'.

Just ask if you face problems.


Just one comment.
Right now it is a good idea to stay with WgetTests.pm. Please don't rename it. 
We just moved it from WgetTest.pm to WgetTests.pm (for some technical / 
organisational reason, to avoid developers having problems).


Regards, Tim


> 
> Best regards,
> 
> /Pär
> 
> 2014-10-30 20:54 GMT+01:00 <address@hidden>:
> > From: Pär Karlsson <address@hidden>
> > 
> > ---
> > 
> >  tests/ChangeLog                  |  12 +
> >  tests/FTPServer.pm               | 597
> > 
> > +++++++++++++++++++++++----------------
> > 
> >  tests/FTPTest.pm                 |  36 +--
> >  tests/HTTPServer.pm              | 208 +++++++++-----
> >  tests/HTTPTest.pm                |  28 +-
> >  tests/Makefile.am                |   2 +-
> >  tests/Test-proxied-https-auth.px |   2 +-
> >  tests/WgetFeature.pm             |  41 ++-
> >  tests/WgetTest.pm                | 423 +++++++++++++++++++++++++++
> >  tests/WgetTests.pm               | 334 ----------------------
> >  10 files changed, 993 insertions(+), 690 deletions(-)

signature.asc
Description: This is a digitally signed message part.