Re: [Bug-wget] [PATCH 1/5] use pkg-config to check zlib deps if available

[Giuseppe Scrivano]

Hi Darshit,

Darshit Shah <address@hidden> writes:

> On 11/01, Giuseppe Scrivano wrote:
>>Darshit Shah <address@hidden> writes:
>>
>>> On 10/31, Mike Frysinger wrote:
>>>>On 31 Oct 2014 16:50, Giuseppe Scrivano wrote:
>>>>> Mike Frysinger <address@hidden> writes:
>>>>> > Newer versions of these packages ship with pkg-config files, so if we 
>>>>> > can
>>>>> > detect it via those, do so.  If that fails, fall back to the old 
>>>>> > methods.
>>>>>
>>>>> so far I always tried to stay as far away from pkg-config as possible,
>>>>> but if that is used by distro maintainers then we should probably
>>>>> reconsider it.
>>>
>>> I favour pkg-config too. It would make our lives a lot more simpler.
>>>>
>>>>distro maintainers extremely prefer it over each package doing its own 
>>>>(limited
>>>>testing) in build files (i.e. configure) or using legacy xxx-config scripts.
>>>>pkg-config is way more reliable than either of those.
>>>>-mike
>>
>>ok thanks for your opinions.  I've added the changelog entries and
>>going to push the series.
>>
> I sent out a patch that squashes all the patches into a single
> one. Since they're logically related, I think we should push them as a
> single patch.

sorry for pushing it without explaining why.  I think it still makes
sense to keep them in different patches.  Each change in this series is
logically complete and the smaller patchs can be, the better it turns in
case we need to git bisect the history.

Regards,
Giuseppe