Re: [Bug-wget] [PATCH] Stylistic and idiomatic cleanups in Perl tests

[Pär Karlsson]

Attached patch adresses the problem and fixes 'make distcheck' for me.
Tested under perl-5.20.1 and perl-5.8.9 (all in between should be OK, as
long as the modules below are installed).

It might be worth noting (even though the Perl test suite is slowly being
deprecated(?)) that you need two Perl dependent modules in order to make
the test suite run at all. They are usually not, AFAIK, bundled with the
standard perl on most distrubutions, or installed by default:

* HTTP::Daemon (dev-perl/HTTP-Daemon on Gentoo, libhttp-daemon-perl on
Debian, etc.)
* IO::Socket::SSL (dev-perl/IO-Socket-SSL on Gentoo, libio-socket-ssl-perl
on Debian, etc.)

In case you don't have those installed, the 'make distcheck' will fail,
might be worth noting in a README or something.

Anyway, please review and and check. Should solve the problem :-)

/Pär



2014-11-03 12:27 GMT+01:00 Tim Ruehsen <address@hidden>:

> On Sunday 02 November 2014 21:31:50 Pär Karlsson wrote:
> > I realized I got rid of one warning only to produce another in the test
> > suite.
> >
> > The issue was the syntax of the eval statement in WgetFeature.pm that
> > essentially does what we want, but that produces a warning about using a
> > string or array in void context (meaning it should't normally do
> something,
> > except that we are doing in in an eval() ).
> >
> > Changed the eval into a proper string eval, which stops the warning.
> >
> > Sorry, about the messup!
> >
> > Best regards,
> >
> > /Pär
>
> Hi Pär,
>
> I realized that 'make distcheck' now fails. Something is broken with the
> path
> that searches modules on.
>
> It was commit 8078adee7f4be04040f12232be8698236153c1f1 (Stylistic and
> idiomatic cleanups in Perl tests).
>
> Please take a look at it, maybe you can fix it.
>
> Tim
>

0001-Fixed-finding-WgetFeature.cfg-when-in-separate-build.patch
Description: Binary data