Re: [Bug-wget] [Bug-Wget] Wget closes connection despite Keep-Alive

[Giuseppe Scrivano]

Hi Darshit,

Darshit Shah <address@hidden> writes:

> * Off-topic:
> Looking at the condition, there's one comparison that we can avoid:
> hs->restval > 0
> contlen >= 0
> hs->restval >= contlen
>
> In this case, hs->restval > 0 is redundant and un-needed.

good catch, we can surely drop the first comparison.

> The reason why I came across this was that I needed Wget to maintain a
> persistent connection, and that was exactly what the server
> expected. However, Wget went ahead and closed the connection. This
> *missing feature* was precisely what I was looking for.
>
> Also, this behaviour will become a bug with SPDY and HTTP/2 since the
> server will try to use the open connection to suggest other resources
> which the client may ask for.
>
>
> I'm waiting for Giuseppe's views on this. Else, I'll split the
> condition into two parts, with the first one called CLOSE_FINISH
> instead of CLOSE_INVALIDATE

feel free to split it and leave the connection open on a
HTTP_STATUS_RANGE_NOT_SATISFIABLE.

Regards,
Giuseppe