Re: [Bug-wget] [Patch] src/main.c

[Darshit Shah]

On 11/11, Gisle Vanem wrote:
> I've managed to build Wget using MSVC ver. 16 (Visual C Express 2010).
> after some tweeking of Gnulib etc. Besides all the problems with the
> C99 syntax of data after code, there is this little issue with
> '_Noreturn':
>
> --- orig/main.c       2014-10-30 13:33:41 +0000
> +++ main.c      2014-11-10 15:48:38 +0000
> @@ -117,8 +117,8 @@
> ♀
> /* Definition of command-line options. */
>
> -static void print_help (void);
> -static void print_version (void);
> +static void _Noreturn print_help (void);
> +static void _Noreturn print_version (void);
>
> ------------------
>
> In Gnulib's ../build-aux/snippet/_Noreturn.h, this
> expands to '__declspec(noreturn)' for MSVC. Seems
> gcc is more forgiving in omitting a declspec in the
> prototype vs. implementation. Can you fix this?
Not just GCC, but even LLVM/Clang seems to be forgiving about this. Thanks for 
fixing it though!


--
Thanking You,
Darshit Shah

pgpO7zVPZF5FU.pgp
Description: PGP signature