Re: [Bug-wget] [Bug-Wget] Configure flag to disable assert

[Darshit Shah]

On 11/14, Dagobert Michelsen wrote:
> Hi Darshit,
>
> > Am 14.11.2014 um 20:01 schrieb Darshit Shah <address@hidden>:
> >
> > Assertions are good programming practice. However, as the recent assert I added 
> > shows us, they should not exist on the client side installations of our 
> > software. Assertions are meant for development use only.
> >
> > Hence, I've added a new configure option, --disable-assert which will eliminate 
> > all assertions from the codebase before compilation.
>
> Is this necessary? I mean if you add -DNDEBUG to CPPFLAGS asserts are already 
> not
> compiled in.
That's very true. But as I have come to realize, not a lot of people are either:
a. Aware of that fact
b. Using the -DNDEBUG option.

On the other hand, providing this configure option and making a note in the NEWS 
section, I am hoping that more maintainers will use the --disable-assert flag 
and remove assertions from the compiled code.

Originally, my intention was to disable assertions by default and have the 
developers enable them explicitly. However, I was unable to find a simple way of 
doing so. I may still implement that sometime very soon.
> Best regards
>
>  — Dago
>
> --
> "You don't become great by trying to be great, you become great by wanting to 
> do something,
> and then doing it so hard that you become great in the process." - xkcd #896


--- end quoted text ---

--
Thanking You,
Darshit Shah

pgpyJfp31Z0g7.pgp
Description: PGP signature