[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Bug-wget] [PATCH] Fix some clang-analyzer warnings
From: |
Tim Rühsen |
Subject: |
[Bug-wget] [PATCH] Fix some clang-analyzer warnings |
Date: |
Tue, 18 Nov 2014 20:54:30 +0100 |
User-agent: |
KMail/4.14.2 (Linux/3.16.0-4-amd64; KDE/4.14.2; x86_64; ; ) |
Fixes these warnings:
gnutls.c:457:3: warning: Value stored to 'err' is never read
err = 0;
http-ntlm.c:477:5: warning: Value stored to 'size' is never read
size = (size_t) snprintf (ntlmbuf, sizeof(ntlmbuf),
http.c:1479:3: warning: Attempt to free released memory
xfree_null (hs->error);
The last one *might* result in a crash under special circumstances.
I think we should just have one xfree() macro instead of two (xfree and
xfree_null, some parts of the code even use free() directly).
IMHO, a free'd pointer should always be set to NULL afterwards (as a good
programming convention). I suggest the following macro
#define xfree(a) do { if (a) { free ((void *) (a)); a = NULL; } } while (0)
What do you think ?
Tim
0001-Fix-warnings-from-clang-analyzer-3.6.patch
Description: Text Data
signature.asc
Description: This is a digitally signed message part.
- [Bug-wget] [PATCH] Fix some clang-analyzer warnings,
Tim Rühsen <=