Re: [Bug-wget] [PATCH] Fixing C89 warnings

[Gisle Vanem]

Tim Ruehsen wrote:

> You don't have the latest git version, at least your diff isn't based on it.

Okay. I was too quick. It builds fine with MSVC v16 except
for http.c and the rubbish in progress.c. See [1] below.
Diffs for http.c:

--- ../Git-latest/src/http.c    2014-11-20 15:39:55 +0000
+++ ./http.c    2014-11-20 15:54:05 +0000
@@ -1191,8 +1191,9 @@
 parse_content_disposition (const char *hdr, char **filename)
 {
   param_token name, value;
-  *filename = NULL;
   bool is_url_encoded = false;
+
+  *filename = NULL;
   for ( ; extract_param (&hdr, &name, &value, ';', &is_url_encoded);
         is_url_encoded = false)


> I guess MSVC 16 can be used on WinXP while MSVC 18 is for Win7 and up ?

Correct. I do have another PC with Win 8.1 and VC Express 2013
(MSVC v18), but feel more at ease with Win-XP ATM.

> Please redo your diff and check if the errors below still exist (looks like
> size_t is not available !?).

No problem with 'size_t' on MSVC v16.

[1]:
  #else
  # define count_cols(mbs) ((int)(strlen(mbs)))
  # define cols_to_bytes(mbs, cols, *ncols) do {  \
      *ncols = cols;                              \
      bytes = cols;                               \
  }while (0)
  #endif

(I forgot to add 'HAVE_WCWIDTH' and 'HAVE_MBTOWC').

And BTW. Since large-files are default on Windows (wgint is
  __int64), this patch should be applied:

--- ../Git-latest/src/build_info.c.in   2014-10-30 13:33:41 +0000
+++ ./build_info.c.in   2014-11-05 13:28:49 +0000
@@ -2,11 +2,12 @@
 https           defined HAVE_SSL
 ipv6            defined ENABLE_IPV6
 iri             defined ENABLE_IRI
-large-file      SIZEOF_OFF_T >= 8
+large-file      SIZEOF_OFF_T >= 8 || defined WINDOWS


--gv