Re: [Bug-wget] wcat?

[Dagobert Michelsen]

Hi,

> Am 20.11.2014 um 08:55 schrieb Ángel González <address@hidden>:
> 
> On 20/11/14 07:34, Darshit Shah wrote:
>> And talking about legalities, I'm hoping you already have signed the 
>> assignment papers because otherwise that's even more work, before we can add 
>> this to the source. :-)
> Come on, that's not needed for trivial changes :)
> The given shell script is a perfect example of trivial patch.
> 
> And regarding the "required options", I would keep the
> parameter-checking cruft to a minimum.

I would consider this worse than not including it because if you don’t do it 
right
you get all sorts of problems. My main concern is the it should hardcode to
$(bindir)/wget as passed to configure or e.g. /opt/csw/bin/wcat with 
/opt/csw/bin
not in the path would result in invoking the wrong (or none at all) wget. This
requires substitution during configure and not being put in contrib.


Best regards

  — Dago



-- 
"You don't become great by trying to be great, you become great by wanting to 
do something,
and then doing it so hard that you become great in the process." - xkcd #896

smime.p7s
Description: S/MIME cryptographic signature