bug-wget
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug-wget] Disable assertions by default


From: Darshit Shah
Subject: Re: [Bug-wget] Disable assertions by default
Date: Fri, 21 Nov 2014 13:19:18 +0530
User-agent: Mutt/1.5.23 (2014-03-12)

On 11/20, Ángel González wrote:
On 20/11/14 15:29, Darshit Shah wrote:
--- a/src/progress.c
+++ b/src/progress.c
@@ -992,6 +992,7 @@ create_image (struct bar_progress *bp, double 
dl_total_time, bool done)
     {
       int percentage = 100.0 * size / bp->total_length;
       assert (percentage<= 100);
+      assert (false);

       if (percentage<  100)
         sprintf (p, "%3d%%", percentage);
-- 2.1.3
Surely you didn't want to include this :)

Shit! No, that was meant to be for my own debugging purposes. I was trying to see if I could induce an assertion failure. Good thing the patch goes through review first.

I've fixed this in the attached patch.

--
Thanking You,
Darshit Shah

Attachment: 0001-Assertions-are-now-disabled-by-default.patch
Description: Text Data

Attachment: pgpDhASAiwLOY.pgp
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]