Re: [Bug-wget] ARRG (was: remote_to_utf8: cut off part of condition always false)

[Jakub Cajka]

Sorry for more spamming, I'm to slow..., already sent, the same request... 
Thanks for attention :).

----- Original Message -----
From: "Tim Ruehsen" <address@hidden>
To: address@hidden
Sent: Friday, November 21, 2014 9:42:37 AM
Subject: Re: [Bug-wget] ARRG (was: remote_to_utf8: cut off part of condition    
always false)

On Friday 21 November 2014 13:56:01 Darshit Shah wrote:
> On 11/21, Daniel Stenberg wrote:
> >Hey
> >
> >Attached is a tiny patch that fixes a compiler warning as the right
> >part of the condition always evaluates to true when a signed char is
> >checked if it is larger than 127.
> 
> Some would term this as defensive programming. Though I think if a signed
> char were to exceed 127 for any reason, such checks will be the least of
> the problems for Wget.
> 
> I pushed this patch after adding the required ChangeLog entry. (Another
> ancient relic, I want to get rid of)

You just make Wget fail on systems with char being unsigned (arm64, ppc64). 
That is the reason why this line has been introduced and the warning not being 
fixed !!!

It was a bug fix some just weeks ago (I remember someone from Redhat !?).

So please add a comment and revert the commit.

Tim