bug-wget
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug-wget] ARRG (was: remote_to_utf8: cut off part of condition alwa


From: Jakub Cajka
Subject: Re: [Bug-wget] ARRG (was: remote_to_utf8: cut off part of condition always false)
Date: Fri, 21 Nov 2014 08:11:32 -0500 (EST)

Thanks for quick response, works and looks good :). Sorry for causing this mess 
with initial patch... missed that warning on x86... :(

Thanks
Jakub

----- Original Message -----
From: "Tim Ruehsen" <address@hidden>
To: address@hidden
Sent: Friday, November 21, 2014 10:55:33 AM
Subject: Re: [Bug-wget] ARRG (was: remote_to_utf8: cut off part of condition    
always false)

On Friday 21 November 2014 10:36:58 Tim Ruehsen wrote:
> On Friday 21 November 2014 10:12:18 Daniel Stenberg wrote:
> > On Fri, 21 Nov 2014, Tim Ruehsen wrote:
> > > Jakub, since I have no 'unsigned char' system running, could you amend
> > > and
> > > test the check so that it does not give a compiler warning on 'signed'
> > > systems ?
> > 
> > How about always doing the check using unsigned? See attachment.
> 
> Yes, but you don't need ustr.
> 
> If you don't mind, I would apply this
> 
>       const unsigned char *p;
>       for (p = (unsigned char *) str; *p; p++)
> 
> Tim

I pushed it.

Tim



reply via email to

[Prev in Thread] Current Thread [Next in Thread]