bug-wget
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug-wget] [PATCH] Change testenv/Test-auth-both.py from XFAIL to a


From: Darshit Shah
Subject: Re: [Bug-wget] [PATCH] Change testenv/Test-auth-both.py from XFAIL to a normal test
Date: Fri, 21 Nov 2014 21:13:45 +0530

Thanking You,
Darshit Shah
Sent from mobile device. Please excuse my brevity
On 21-Nov-2014 8:45 pm, "Tim Ruehsen" <address@hidden> wrote:
>
> I had two issues with the above mentioned test.
>
> 1. XFAIL is not common to people - we had some confusion on the mailing
list.

Xfail is standard parlance for expected failures. This is also documented
in the readme file. Xfail is not something we introduced but is available
in autotools as a standard feature.
> 2. XFAIL is true for a test even if it fails out of *any* reason.
> Example: When testing on a virtual machine without python3, 'make check'
still
> happily reports XFAIL: 1 instead of report failure of all tests.
>
This specific issue should be handled in the configure file. I'll try and
hack it together tomorrow.

I'm against this patch, since currently make check reports exactly as it
should. The test is expected to fail. I do not know of any scenario where
this particular test will fail for unexpected reasons. What you describe
occurs when all tests fail.

Let's keep the expected failures since it is a reminder of features that we
currently lack.

> I made up a patch to make the test behave like all other tests.
>
> If nobody complains I'll push it this evening (~ 5h from now).
>
> Tim


reply via email to

[Prev in Thread] Current Thread [Next in Thread]