[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Bug-wget] [PATCH 6/8] Add extern declaration for program_arsgstring
|
From: |
Tim Ruehsen |
|
Subject: |
Re: [Bug-wget] [PATCH 6/8] Add extern declaration for program_arsgstring |
|
Date: |
Mon, 24 Nov 2014 15:13:40 +0100 |
|
User-agent: |
KMail/4.14.2 (Linux/3.16.0-4-amd64; KDE/4.14.2; x86_64; ; ) |
On Monday 24 November 2014 19:21:16 Darshit Shah wrote:
> The argstring in a normal program execution isn't a constant but is
> constructed dynamically from the command line options.
>
> The way the argstring is constructed, this var cannot be a const.
Sorry Darshit,
I didn't have your patch in mind.
Just this morning I pushed a (trivial) patch to make both program_name and
program_argstring const.
I agree with Giuseppe, they should be const. The more const we use, the better
we can detect programming faults right from the beginning.
Tim
- [Bug-wget] [PATCH 2/8] Add extern declaration for version.c strings, (continued)
- [Bug-wget] [PATCH 2/8] Add extern declaration for version.c strings, Darshit Shah, 2014/11/22
- [Bug-wget] [PATCH 1/8] Mark unused paramter in utils.c, Darshit Shah, 2014/11/22
- [Bug-wget] [PATCH 3/8] Fix missing extern declaration error for build_info.pl, Darshit Shah, 2014/11/22
- [Bug-wget] [PATCH 5/8] Make extern declaration for program_name, Darshit Shah, 2014/11/22
- [Bug-wget] [PATCH 4/8] Declare extern numurls in common header, Darshit Shah, 2014/11/22
- [Bug-wget] [PATCH 6/8] Add extern declaration for program_arsgstring, Darshit Shah, 2014/11/22
- [Bug-wget] [PATCH 7/8] Remove defensive assert in cookies.c, Darshit Shah, 2014/11/22
- [Bug-wget] [PATCH 8/8] Supplement logical assumption assert with error message, Darshit Shah, 2014/11/22
- Re: [Bug-wget] Fix various compiler warnings, Tim Rühsen, 2014/11/22
- Re: [Bug-wget] Fix various compiler warnings, Giuseppe Scrivano, 2014/11/24