[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Bug-wget] [PATCH] ftp: fix invalid pointer dereference in getftp()
From: |
Tim Ruehsen |
Subject: |
Re: [Bug-wget] [PATCH] ftp: fix invalid pointer dereference in getftp() |
Date: |
Tue, 16 Dec 2014 16:02:44 +0100 |
User-agent: |
KMail/4.14.2 (Linux/3.16.0-4-amd64; KDE/4.14.2; x86_64; ; ) |
On Tuesday 16 December 2014 11:15:32 Cong Ma wrote:
> In ftp.c, the return value of ftp_response() is not checked before using
> the pointer respline. Subsequent call ftp_expected_bytes (respline)
> will possibly dereference the uninitialized pointer, thereby crashing
> wget.
>
> This patch moves the dereference of respline after the return-value
> check, which should fix the crash.
>
> The problem has been reported against Fedora's wget package[1].
>
> Thanks for reviewing and best wishes,
Thanks, pushed.
Tim
signature.asc
Description: This is a digitally signed message part.