[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Bug-wget] Building and testing wget 1.16.1 on MinGW
From: |
Tim Rühsen |
Subject: |
Re: [Bug-wget] Building and testing wget 1.16.1 on MinGW |
Date: |
Sat, 20 Dec 2014 12:26:04 +0100 |
User-agent: |
KMail/4.14.2 (Linux/3.16.0-4-amd64; KDE/4.14.2; x86_64; ; ) |
Am Samstag, 20. Dezember 2014, 10:37:30 schrieb Eli Zaretskii:
> > From: Tim Ruehsen <address@hidden>
> > Date: Fri, 19 Dec 2014 12:53:13 +0100
> >
> > > 4. "make check" fails to link test programs, such as unit-tests.exe,
> > >
> > > because it doesn't link against libintl. Again, not sure how best
> > > to fix that (wget itself does get linked against libintl and
> > > libiconv).
> >
> > Dunno.
>
> Btw, I encountered a similar problem building wget on GNU/Linux,
> except that in that case what was missing was -lrt, without which
> clock_gettime and friends cannot be resolved. So there seems to be
> some general problem here.
Ah, ok. clock_gettime/-lrt problem has been solved by 4.11.2014.
What we (basically, through m4/wget.m4) do is
AC_CHECK_FUNCS(clock_gettime, [], [
AC_CHECK_LIB(rt, clock_gettime)
])
Than we use LIB_CLOCK_GETTIME in tests/Makefile.am
LDADD = ../src/libunittest.a ../lib/libgnu.a $(LIBS) $(LIB_CLOCK_GETTIME)
Maybe you could add a similar piece of code for libintl.
(Since I can't reproduce and can't test, I need your help here.)
A (for you) working patch would be great !
> > > Btw, to debug the Test-N issue, I had to add the time stamps being
> > > compared to the Perl script that runs the test. It would be nice to
> > > have that in the tests by default, because just by looking at the time
> > > stamps, one can immediately understand in what direction to look for
> > > the problem (in my case I saw a difference of 3600 sec).
> >
> > Since I am not 100% sure what you are talking about and you already
> > extended the (or a) Test-N, please send us diff/patch.
>
> Here it is:
>
> --- tests/WgetTests.pm~ 2014-11-01 23:07:48.000000000 +0200
> +++ tests/WgetTests.pm 2014-12-20 10:34:05.920875000 +0200
> @@ -319,7 +319,7 @@ sub _verify_download
> = stat $filename;
>
> $mtime == $filedata->{'timestamp'}
> - or return "Test failed: wrong timestamp for file
> $filename\n"; + or return "Test failed: wrong timestamp for
> file $filename: expected = $filedata->{'timestamp'}, actual = $mtime\n"; }
>
> }
Thanks, Eli.
I pushed it.
Tim
signature.asc
Description: This is a digitally signed message part.
- Re: [Bug-wget] Building and testing wget 1.16.1 on MinGW, (continued)
- Re: [Bug-wget] Building and testing wget 1.16.1 on MinGW, Eli Zaretskii, 2014/12/19
- Re: [Bug-wget] Building and testing wget 1.16.1 on MinGW, Tim Ruehsen, 2014/12/19
- Re: [Bug-wget] Building and testing wget 1.16.1 on MinGW, Eli Zaretskii, 2014/12/19
- Re: [Bug-wget] Building and testing wget 1.16.1 on MinGW, Eli Zaretskii, 2014/12/21
- Re: [Bug-wget] Building and testing wget 1.16.1 on MinGW, Tim Rühsen, 2014/12/21
- Re: [Bug-wget] Building and testing wget 1.16.1 on MinGW, Eli Zaretskii, 2014/12/22
- Re: [Bug-wget] Building and testing wget 1.16.1 on MinGW, Tim Rühsen, 2014/12/23
- Re: [Bug-wget] Building and testing wget 1.16.1 on MinGW, Tim Rühsen, 2014/12/25
- Re: [Bug-wget] Building and testing wget 1.16.1 on MinGW, Eli Zaretskii, 2014/12/25
Re: [Bug-wget] Building and testing wget 1.16.1 on MinGW, Eli Zaretskii, 2014/12/20