Re: [Bug-wget] FTP tests fail on MS-Windows

[Tim Rühsen]

Am Samstag, 20. Dezember 2014, 22:06:01 schrieb Eli Zaretskii:
> > From: Tim Rühsen <address@hidden>
> > Date: Sat, 20 Dec 2014 18:18:20 +0100
> > 
> > > But on Windows the same test yields this:
> > >      Running test Test-ftp-bad-list
> > >      Calling /d/gnu/wget-1.16.1/tests/../src/wget -nH -Nc -r
> > > 
> > > ftp://localhost:3244/ --2014-12-19 18:14:54--  ftp://localhost:3244/
> > > 
> > >           => '.listing'
> > >           
> > >      Resolving localhost (localhost)... 127.0.0.1
> > >      Connecting to localhost (localhost)|127.0.0.1|:3244... connected.
> > >      Logging in as anonymous ... Logged in!
> > >      ==> SYST ... done.    ==> PWD ... done.
> > >      ==> TYPE I ... done.  ==> CWD not needed.
> > >      ==> PASV ... done.    ==> LIST ... _LIST_command - dir is: /
> > >      done.
> > >      
> > >      .listing                [ <=>                  ]      88  --.-KB/s 
> > >       in
> > > 
> > > 0s
> > > 
> > >      2014-12-19 18:14:54 (818 KB/s) - '.listing' saved [88]
> > >      
> > >      Removed '.listing'.
> > >      --2014-12-19 18:14:54--  ftp://localhost:3244/
> > >           
> > >           => 'index.html'
> > >           
> > >      ==> CWD not required.
> > >      ==> SIZE  ... done.
> > >      
> > >      ==> PASV ... done.    ==> RETR  ...
> > >      No such file ''.
> > > 
> > > Note the 'index.html' thing -- that's where the difference between the
> > > two systems begins.  Looks like the server behaves differently,
> > > doesn't it?
> > > 
> > > Does anyone have a clue what is going on here?  Any bells ring for
> > > anyone?
> > 
> > I fixed a locale thing a while ago. It was FTPServer.pm using strftime()
> > generating non-english month names. Wget expects english month names (of
> > course). What fixed that for me was a change in WgetTests.pm:
> > 
> > ...
> > 
> >         # FTP Server has to start with english locale due to use of
> >         strftime
> > 
> > month names in LIST command
> > 
> >         setlocale(LC_ALL, 'C');
> >         $self->_launch_server(
> 
> Thanks.  But how can this explain the 'index.html' thingy appearing in
> the FTP listing, instead of the expected afile.txt etc.?

The .listing file can't be parsed correctly when the month names are incorrect.

> > Do you have a recent version of the auto* tools installed ?
> 
> For some value of "recent", yes.  How are autotools related to this
> issue?

'make check' explicitly sets LC_ALL=C. For some reason it sems to fail in your 
environment. You could add a print line to the server perl code to see what 
the settings are it runs with.


> > Maybe you can tell me your locale settings and/or try using the same
> > locale
> > settings on Gnu/Linux.
> 
> It's the Windows equivalent of en_US.cp1255.
> 
> > 'make check' explicitly sets LC_ALL=C.
> > So i could produce these errors only with
> > TESTS_ENVIRONMENT="LC_ALL=de_DE.utf8" make check
> 
> I see the same problems no matter whether I run "make check" or the
> individual tests from the Bash prompt.

Either auto* tools are broken (or let's say the test suite code) or your 
environment behavesw unexpected.

But I simply can't fix it for you, I just don't (and won't) have your system / 
environment and can't reproduce these issues. I just can guess from what you 
tell me. But I know, there are a few Windows users / developers reading this. 
Maybe they can help or bring some light !?

Tim

signature.asc
Description: This is a digitally signed message part.