bug-wget
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug-wget] [patch] uuid generation in warc.c


From: Tim Ruehsen
Subject: Re: [Bug-wget] [patch] uuid generation in warc.c
Date: Thu, 08 Jan 2015 10:39:17 +0100
User-agent: KMail/4.14.2 (Linux/3.16.0-4-amd64; KDE/4.14.2; x86_64; ; )

On Tuesday 06 January 2015 14:09:39 Gisle Vanem wrote:
> > I would prefer dynamic linking (-lrpcrt4).
> 
> You mean use LoadLibrary ("rpcrt4.dll") at run-time?
> That would be cleaner. So that should be done in mswindows.c
> at init-time (in ws_startup()?).

I didn't mean it, but yes, that would be the best solution.
Eli Zaretskii already already stated that.

IMO, best place would be in warc_init(). That would avoid loading the library 
if the user does not request WARC.

> > If rpcrt4.lib/.dll is *not* a basic windows library, you should check for
> > the library in configure.ac (case "$host_os" in ...).
> 
> Then there would be no need for such AC checks.

Loading at run-time won't need AC checks.

Tim

Attachment: signature.asc
Description: This is a digitally signed message part.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]