bug-wget
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug-wget] Prepend non-HTML links when downloading recursively


From: Darshit Shah
Subject: Re: [Bug-wget] Prepend non-HTML links when downloading recursively
Date: Wed, 28 Jan 2015 13:48:37 +0530

On Tue, Jan 27, 2015 at 9:33 PM, John Peterson <address@hidden> wrote:
> ## git patch
>
>>in order to add your patch to wget, could you please send the complete patch 
>>in git's format-patch format ?
>
> its in https://github.com/mirror/wget/pull/2.patch

This is extremely rudimentary and works only to show a proof of concept.

Apart from what Tim asked for (switch and documentation), you would
also have to add the relevant debug statements to ensure that when we
look at a debug log, we know exactly what is happening. The current
DEBUGP message will have to be changed to reflect the new working.

Also, I would like to see a test case that shows how the two differ.
This allows us to prevent regressions in the future.


Beyond, the technical items, we will also need to complete some
legalities. You will be required to sign the copyright assignment
agreement with the FSF before we can merge this patch into our
codebase.


P.S.: Please ensure that all discussion occurs on-list here and not
off-list in a GitHub repository that none of us even look at.

-- 
Thanking You,
Darshit Shah



reply via email to

[Prev in Thread] Current Thread [Next in Thread]