[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug-wget] Prepend non-HTML links when downloading recursively

From: Darshit Shah
Subject: Re: [Bug-wget] Prepend non-HTML links when downloading recursively
Date: Thu, 29 Jan 2015 09:54:24 +0530

On Wed, Jan 28, 2015 at 10:45 PM, John Peterson
<address@hidden> wrote:
> ## make it optional
>>you already have that in your 'recurse' branch. Take that, undo the changes 
>>to src/recur.c and take your changes from 'recurse2' branch.
> k it's done https://github.com/mirror/wget/pull/2/files
Again, could we please start sharing the patch directly on the mailing
list? Not all of us work with a GUI browser for emails.

I don't know how to download the commit locally for testing on my own
machine. Please share the patch directly with us, in git format-patch
style. It really makes things a lot easier for all of us.

> ## debug message
>>you would also have to add the relevant debug statements to ensure that when 
>>we look at a debug log, we know exactly what is happening. The current DEBUGP 
>>message will have to be changed to reflect the new working.
> i changed the DEBUGP that say Enqueuing to Appending/Prepending to tell whats 
> happening
> ## test
>>I would like to see a test case that shows how the two differ.
> there's a test in https://github.com/mirror/wget/pull/2#issue-53548650 /test 
> that compare them
No, I meant a live test for the Wget Test Suite. You'll find the test
suite in the testenv/ directory. We need to add a test that ensures
that the Wget downloads files in the correct order as expected.

> ## i release the copyright
>>You will be required to sign the copyright assignment agreement with the FSF 
>>before we can merge this patch into our codebase.
> sounds like a lot of work. i release the copyright. i dont care

I wish it were that easy. I've sent you the copyright assignment form.
You'll have to fill that and send it in first.

Thanking You,
Darshit Shah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]