[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug-wget] Issue with --content-on-error and --convert-links

From: Yousong Zhou
Subject: Re: [Bug-wget] Issue with --content-on-error and --convert-links
Date: Fri, 30 Jan 2015 21:51:03 +0800

On 29 January 2015 at 21:26, Tim Ruehsen <address@hidden> wrote:
> Hi Yousong,
>> > this patch seems to be incomplete. Do you have a complete patch (e.g. +new
>> > option, + docs) or are you going to work on it ?
>> That patch was only intended as a ephemeral one to see if it can solve
>> the issue reported by Joe at the time.  But checking it again, I now
>> think the patch actually does the right thing.  The reason is that
>> since those --content-on-error pages are downloaded, then links within
>> those pages should be converted as specified by --convert-links.
>> There is no need for a new option for this and the current doc is just
>> fine.  But I will try adding an test cases for this.
> Ah sorry, my fault / misunderstanding.
> Since the patch changes Wget behaviour I would apply it after the next bugfix
> release.
> A test case would be perfect. Please consider creating a python test case (see
> directory testenv). We will move all test cases from perl to python by the
> time.

Well, there they are, with a few fixes for other issues I encountered
when preparing for this.

> Tim

Attachment: 0001-testenv-typo-and-style-fix.patch
Description: Binary data

Attachment: 0002-testenv-allow-color-printer-for-Darwin-platform.patch
Description: Binary data

Attachment: 0003-testenv-fix-http_server.py-with-Response-and-Authent.patch
Description: Binary data

Attachment: 0004-testenv-add-test-case-Test-convert-links-content-on-.patch
Description: Binary data

Attachment: 0005-Fix-content-on-error-option-handling.patch
Description: Binary data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]