Re: [Bug-wget] [patch] uuid generation in warc.c

[Giuseppe Scrivano]

Eli Zaretskii <address@hidden> writes:

> [Please CC me directly, as I'm not subscribed to the list.]
>
>> Date: Sat, 14 Feb 2015 14:33:20 +0100
>> From: Gisle Vanem <address@hidden>
>> CC: address@hidden
>> 
>> Eli Zaretskii wrote:
>> 
>> > +  if (rpc_uuid_avail == -1)
>> > +    {
>> > +      HMODULE hm_rpcrt4 = LoadLibrary ("Rpcrt4.dll");
>> > +
>> > +      if (hm_rpcrt4)
>> > +  {
>> > +    pfn_UuidCreate =
>> > +      (UuidCreate_proc) GetProcAddress (hm_rpcrt4, "UuidCreate");
>> > +    pfn_UuidToString =
>> > +      (UuidToString_proc) GetProcAddress (hm_rpcrt4, "UuidToStringA");
>> > +    pfn_RpcStringFree =
>> > +      (RpcStringFree_proc) GetProcAddress (hm_rpcrt4, "RpcStringFreeA");
>> > +    if (pfn_UuidCreate && pfn_UuidToString && pfn_RpcStringFree)
>> > +      rpc_uuid_avail = 1;
>> > +    else
>> > +      rpc_uuid_avail = 0;
>> > +  }
>> 
>> Shouldn't there be an:
>>       else
>>          rpc_uuid_avail = 0;
>> for the 'if (hm_rpcrt4)' part.
>
> Yes, thanks.  Updated patch is attached.
>
> 2015-02-14  Eli Zaretskii  <address@hidden>
>           Gisle Vanem  <address@hidden>
>
>       * warc.c (windows_uuid_str) [WINDOWS]: New function specific to
>       MS-Windows.
>       (warc_uuid_str) [WINDOWS]: If windows_uuid_str succeeds, use its
>       result; otherwise use the fallback method.

I went ahead and pushed the patch.

Thanks,
Giuseppe