bug-wget
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug-wget] [Patch] Fix few memory leaks reported by coverity


From: Darshit Shah
Subject: Re: [Bug-wget] [Patch] Fix few memory leaks reported by coverity
Date: Sat, 7 Mar 2015 21:20:58 +0530

Any updates? Else I push this patch on Monday morning.

On Tue, Mar 3, 2015 at 4:43 PM, Darshit Shah <address@hidden> wrote:
> On Tue, Mar 3, 2015 at 3:20 PM, Tim Ruehsen <address@hidden> wrote:
>> On Tuesday 03 March 2015 15:10:39 Darshit Shah wrote:
>>> Any updates on these patches?
>>>
>>> On Sun, Mar 1, 2015 at 7:48 PM, Darshit Shah <address@hidden> wrote:
>>> > Earlier today, I ran Coverity on the latest HEAD of Wget. I've fixed some
>>> > of the potential memory leaks that Coverity reported. Please take a look
>>> >
>>> > --
>>> > Thanking You,
>>> > Darshit Shah
>>
>> I just had time for a quick look, so I can only give you the advice to run 
>> the
>> test suite with valgrind before you push it.
>
> I did indeed run it through valgrind once. However, none of these
> fixes actually had a test case that caught a leak through valgrind.
> Maybe I should couple them all with valid test cases
>
>>
>> Also, Wget does not free memory on exit by purpose. Not sure if Coverity
>> respects this.
>
> I mark them as intentional / not a bug on coverity. The above fixes
> are all in cases where the only pointer to an allocated memory goes
> out of scope. In this scenario, the OS will not be able to reclaim the
> memory back.
>
>>
>> Tim
>
>
>
> --
> Thanking You,
> Darshit Shah



-- 
Thanking You,
Darshit Shah



reply via email to

[Prev in Thread] Current Thread [Next in Thread]