Re: [Bug-wget] segfault encountered after HUGE recursive scrape

[Tim Ruehsen]

On Monday 09 March 2015 10:41:40 Gabriel L. Somlo wrote:
> On Mon, Mar 09, 2015 at 03:08:32PM +0100, Tim Ruehsen wrote:
> > Hi Gabriel,
> > 
> > > wget: convert.c:928: register_redirection: Assertion `file != ((void
> > > *)0)'
> > 
> > The current line number of the assertion is somewhere else.
> 
> Line 928 in convert.c, function register_redirection() is
> 
> 'assert (file != NULL);'

I just checked out 07a350d30c062a813a9ac2a6b3cd8b2ae07f0b26.
'assert (file != NULL);'
is on line 851 !!!
That is quite a big difference to your line number.

Are you on the correct branch (master) ?

> Sadly, that probably makes it impossible to tell exactly where in the
> official commit history I was when I built that binary :(

Ok, but should be pretty close.

> If you can't think of a plausible way to (wrongly) end up with a
> "file == NULL" in register_redirection(), I guess I'll just have

Not in short...

> to restart the whole thing with the latest (carefully built, this time)
> git master and see what happens in another month or so :)

Before you start, replace the assert() with 
if (!file) {
        print something out;
        return;
}

You might miss a file, but that seems better than aborting the process.

Tim