Re: [Bug-wget] [Patch] fix bug #39175 Header value length limited with 256

[Tim Ruehsen]

On Thursday 12 March 2015 22:02:46 Miquel Llobet wrote:
> Increased the header buffer to 8Kb, as there are no limits to the size of
> field name, values or headers themselves. While the current value is big
> enough, other projects such as Apache [1] or nginx have limits of 4-8Kb.
> 
> If we want to allow for arbitrary size headers we should use
> resp_header_strdup instead of resp_header_copy, but this new value should
> be enough.
> 
> --- src/http.c.orig 2015-03-12 21:50:03.000000000 +0100
> +++ src/http.c 2015-03-12 21:04:08.000000000 +0100
> @@ -1695,7 +1695,7 @@
> 
>    char *head;
>    struct response *resp;
> -  char hdrval[512];
> +  char hdrval[8190];
>    char *message;
> 
>    /* Declare WARC variables. */
> 
> [1]: https://httpd.apache.org/docs/2.2/mod/core.html#limitrequestfieldsize
> 
> Miquel Llobet

Hi Miquel,

good idea to accept larger header sizes.

Could you please add a test case with a "long" header line sent by the server 
? Or maybe just extending testenv/Test-cookie-... ?
Set-Cookie header lines may be large, also the Location header (for 
redirection) with a long URL ?

Tim

signature.asc
Description: This is a digitally signed message part.