bug-wget
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug-wget] Patch: Ports test for restrict-filename to python


From: Elita Lobo
Subject: Re: [Bug-wget] Patch: Ports test for restrict-filename to python
Date: Sun, 15 Mar 2015 23:22:36 +0530

Hi,

I have attached a new patch which included the old test files I have
created and 3 more additional test files along with the changes suggested
by Darshit and Zihang. Kindly review it and let me know if my patch
requires further improvements.


Thanks and Regards,
Elita Lobo

On Sun, Mar 15, 2015 at 12:18 AM, Darshit Shah <address@hidden> wrote:

> Hi Elita,
>
> Thanks for the contribution! It's a good set of patches that ports some
> important tests to the Python Test Suite.
>
> However, I had a couple of suggestions. Could you also please retain the
> comments from the original tests about why that particular filename was
> chosen? It adds a lot of value to the test when it explains some of the
> background information.
>
> Also, could you please edit your commit message to be in sync with the GNU
> ChangeLog style commit messages? Take a look at the existing commit
> messages for ideas.
>
> --
> Thanking You,
> Darshit Shah
>

Attachment: 0001-Ports-test-from-old-test-suite-to-Python.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]