Re: [Bug-wget] [GSOC] Bugfixes

[Hubert Tarasiuk]

W dniu 27.03.2015 o 19:49, Giuseppe Scrivano pisze:
> Few comments:
> 
> please configure your ~/.gitconfig to contain your real name, it will be
> used by git commit to set the proper author name.
>  
> minor issue, but will be useful in the long term, we leave two spaes
> after a dot :)
> 
> Both patches miss a ChangeLog style commit message.  We require it as
> part of following the GNU coding standards[1].  We do not modify
> directly the ChangeLog file, as described there, but we generate it
> starting from the git commit logs, please take a look at some commits
> done last month to see how it is done.
> 
I am attaching corrected patches. I additionally corrected few trailing
whitespace errors that were present in the previous version.

>> Now I would like to work on eliminating the other label from gethttp
>> (used for http authentication). I was thinking about eventually moving
>> this logic to http_loop (the socket is closed in this case anyway). Ie.
>> on HTTP_STATUS_UNAUTHORIZED, the function would return to http_loop, and
>> appropriate actions would be taken in that function (ie. another call to
>> gethttp, with modified arguments).
>>
>> Later on, the code handling each http status code could be perhaps
>> isolated and separated into smaller functions.
>>
>> Am I moving in the right directions? Do you have any suggestions?
> 
> Good work!  Yes, it looks like going in the right direction.
> 
> 
>> And BTW what do you think about initializing some pointer variables
>> (like `head` or `resp`) to NULL in order to simplify resources management?
>
> Actually I have suggested something similar on this mailing list few
> days ago.  I think we should move to have a single exit point in gethttp
> where we take care of all the cleanup.  This will require to initialize
> all the pointers to NULL and replace any "return" with a "goto
> cleanup" instead of having several xfree called all over the function.
I see. I will take a closer look at this issue.

Thank you for the hints.
Hubert

0001-Factor-out-set_content_type-function-from-gethttp.patch
Description: Text Data

0002-Transform-read_header-label-and-goto-into-a-loop.patch
Description: Text Data

signature.asc
Description: OpenPGP digital signature