From e96c668c7b403e4ab6e54764284cfa209cc848e5 Mon Sep 17 00:00:00 2001 From: Darshit Shah Date: Sun, 1 Mar 2015 12:45:01 +0530 Subject: [PATCH 1/4] retr.c: Fix two memory leaks when proxy URL is bad Reported by: Coverity bug 1188047 --- src/retr.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/retr.c b/src/retr.c index f12c50f..65d17b4 100644 --- a/src/retr.c +++ b/src/retr.c @@ -772,6 +772,8 @@ retrieve_url (struct url * orig_parsed, const char *origurl, char **file, proxy, error); xfree (url); xfree (error); + xfree (proxy); + iri_free (pi); RESTORE_METHOD; result = PROXERR; goto bail; @@ -781,6 +783,8 @@ retrieve_url (struct url * orig_parsed, const char *origurl, char **file, logprintf (LOG_NOTQUIET, _("Error in proxy URL %s: Must be HTTP.\n"), proxy); url_free (proxy_url); xfree (url); + xfree (proxy); + iri_free (pi); RESTORE_METHOD; result = PROXERR; goto bail; -- 2.3.1