[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Bug-wget] Memory leak in idn_encode; Valgrind suppression file
From: |
Hubert Tarasiuk |
Subject: |
Re: [Bug-wget] Memory leak in idn_encode; Valgrind suppression file |
Date: |
Wed, 08 Apr 2015 18:55:51 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 |
W dniu 06.04.2015 o 22:26, Tim Rühsen pisze:
> Valgrind suppressions are a bit compiler/architecture/distribution dependent.
> Maybe you could you add a comment into the suppression file with these infos.
> As a quick reference and explanation.
I have added a reference URL to Redhat's bugzilla, where the problem is
described.
https://bugzilla.redhat.com/show_bug.cgi?id=678518
> Sorry, one point I missed: Please put the suppression file into EXTRA_DIST
> variable in tests/Makefile.am. Else it won't go into the tarball (make dist).
Done.
I also refactored a little my modification in the Perl script. (Put the
suppression file path into a variable, and use Cwd to get the correct
path, instead of making relative path from the test being run.)
And I also found a simpler way to suppress that error. Valgrind has an
option --partial-loads-ok which would suppress it (more details can be
found in the URL above).
I am not sure which workaround is better for Wget (suppression file vs.
--partial-loads-ok=yes). What do you think?
(The --partial-loads-ok could suppress actual mistakes in future Wget's
code, while the former just works for the particular function in libidn.so.)
> And yes, if you find a proper way to execute the 'testenv' part no matter if
> 'tests' fails or not, a patch would be welcome. It always annoyed me, but not
> enough to put work into it :-(
I will look into it and see if I can find a solution.
Thank you,
Hubert
0002-Add-Valgrind-suppresion-for-libidn.so-at-idna_to_asc.patch
Description: Text Data
signature.asc
Description: OpenPGP digital signature
- Re: [Bug-wget] Memory leak in idn_encode; Valgrind suppression file, (continued)
- Re: [Bug-wget] Memory leak in idn_encode; Valgrind suppression file, Ángel González, 2015/04/06
- Re: [Bug-wget] Memory leak in idn_encode; Valgrind suppression file, Hubert Tarasiuk, 2015/04/06
- Re: [Bug-wget] Memory leak in idn_encode; Valgrind suppression file, Ángel González, 2015/04/06
- Re: [Bug-wget] Memory leak in idn_encode; Valgrind suppression file, Hubert Tarasiuk, 2015/04/08
- Re: [Bug-wget] Memory leak in idn_encode; Valgrind suppression file, Ángel González, 2015/04/08
- Re: [Bug-wget] Memory leak in idn_encode; Valgrind suppression file, Tim Rühsen, 2015/04/10
- Re: [Bug-wget] Memory leak in idn_encode; Valgrind suppression file, Hubert Tarasiuk, 2015/04/11
- Re: [Bug-wget] Memory leak in idn_encode; Valgrind suppression file, Tim Rühsen, 2015/04/11
Re: [Bug-wget] Memory leak in idn_encode; Valgrind suppression file, Tim Rühsen, 2015/04/06
Re: [Bug-wget] Memory leak in idn_encode; Valgrind suppression file, Hubert Tarasiuk, 2015/04/09