Re: [Bug-wget] gethttp cleanup

[Hubert Tarasiuk]

W dniu 01.04.2015 o 17:01, Giuseppe Scrivano pisze:
> Hubert Tarasiuk <address@hidden> writes:
>> When these two issues are dealt with, a common cleanup code for
>> `gethttp` will be easily possible for variables:
>> - req
>> - resp
>> - head
>> - message
>> - type
> 
> I went ahead and pushed your patches!
Hello developers,

I have prepared common cleanup code for the following variables in
http.c (gethttp):
req, resp, head, message, type

I added a single exit point to that function.

It should be a good starting point for further refactoring inside that
function.

Please have a look at the patch and let me know what do you think about it.

I was thinking about a simple macro like:
> #define GETHTTP_CLEAN_RETURN(x) do\
>   {\
>     retval = (x);\
>     goto cleanup;\
>   }\

Then instead of writing:
> retval = XYZ;
> goto cleanup;
we could simply write:
> GETHTTP_CLEAN_RETURN (XYZ);

However I am not sure if it will not obfuscate the code, or if it is
good style/convention.


Thank you,
Hubert

0003-Single-exit-point-and-common-cleanup-code-in-gethttp.patch
Description: Text Data

signature.asc
Description: OpenPGP digital signature