Re: [Bug-wget] no_proxy env ip address range support

[Aníbal Limón]

Hi,

On 15/04/15 18:38, Ángel González wrote:
> On 14/04/15 23:44, Aníbal Limón wrote:
> > Hi guys,
> >
> > I noticed that wget only support domain names entries into no_proxy 
> > env-var, i think will be good to
> > add support for IPs and IP ranges.
> >
> > I reviewed the code and i think can be added to 
> > src/retr.c:no_proxy_match , that will be resolv
> > the host to IP if the no_proxy variable contains an IP and then 
> > validate if match.
> >
> > It would be a change that could add?, Comments?
>
> Wouldn't that end up with the domain being resolved *twice*?
Yes the hostname resolution need to be done only once.
> Also note that it wouldn't be desirable to apply the suffix matching 
> on IPs (CIDR would very nice,
> though -but there's no need for your patch to *also* do that-).
>
> I think the general idea is a good one.

Cheers,
    alimon