bug-wget
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug-wget] Conditional GET requests


From: Hubert Tarasiuk
Subject: Re: [Bug-wget] Conditional GET requests
Date: Tue, 19 May 2015 15:33:36 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0

W dniu 19.05.2015 o 10:14, Tim Ruehsen pisze:> Hi Hubert,
> You could aggregate the code a bit, something like

> Code is a bit more readable if you have a blank line between variable
> declarations and code.
> And it is absolutely ok to have variable declaration and
initialization in one
> line instead of two consecutive lines. Like in
>

W dniu 19.05.2015 o 10:41, Giuseppe Scrivano pisze:
> few minor comments:
>

Thank you for review. I tuned my patches based on your suggestions.
Please let me know if you have any further comments.

Hubert

Attachment: 0001-Implement-timestamp-support-for-local-files-in-teste.patch
Description: Text Data

Attachment: 0002-Support-conditional-GET-in-testenv-server.patch
Description: Text Data

Attachment: 0003-Add-test-for-condget-requests.patch
Description: Text Data

Attachment: 0004-Add-if-modified-since-option.patch
Description: Text Data

Attachment: 0005-Support-If-Modified-Since-header-in-timestamping-mod.patch
Description: Text Data

Attachment: 0006-Include-if-modified-since-option-in-user-manual.patch
Description: Text Data

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]