bug-wget
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug-wget] [Bug-Wget] Bug: Test-proxied-https-auth-keepalive.px does


From: Tim Ruehsen
Subject: Re: [Bug-wget] [Bug-Wget] Bug: Test-proxied-https-auth-keepalive.px does not chdir to test directory
Date: Tue, 16 Jun 2015 10:31:02 +0200
User-agent: KMail/4.14.2 (Linux/4.0.0-1-amd64; KDE/4.14.2; x86_64; ; )

Hi Pär,

many thanks for your work !

But please could you send the patch without the reformatting ?

Regards, Tim

On Tuesday 16 June 2015 00:17:08 Pär Karlsson wrote:
> Here is a suggested patch. I don't know if it will solve the problem, but
> at least there should be diagnostics in the log if something fails.
> 
> Best regards,
> 
> /pär
> 
> 2015-06-15 13:37 GMT+02:00 Pär Karlsson <address@hidden>:
> > I quickly looked at the code in question, and one obvious quick test would
> > be to check the return value of the "unlink" calls (and $! / $ERRNO
> > afterwards) at the two places in the respective .px files where
> > 'needs-auth.txt' is handled.
> > 
> > I've been cleaning up the two tests mentioned but so far have been unable
> > to reproduce the problem with the test file being left over, and I'd be
> > happy to come up with a patch when I'm finished.
> > 
> > Until then, I would suggest a quick change to
> > 
> > if (-e 'needs-auth.txt') {
> > 
> >    unlink 'needs-auth.txt' or warn "Cannot remove 'needs-auth.txt: $!";
> > 
> > }
> > 
> > would be enough to at least pinpoint the problem if it has to do with file
> > permissions.
> > 
> > There are some other potentially problematic constructs in the tests too,
> > (the pipe()/select() calls, for instance, which _might_ cause race
> > conditions in conjunction with the unlink() call), but this is all
> > conjecture on my part; I have not managed to get the tests to fail yet.
> > 
> > /Pär
> > 
> > 2015-06-15 11:56 GMT+02:00 Darshit Shah <address@hidden>:
> >> The two proxied https tests:
> >> Test-proxied-https-auth-keepalive.px
> >> Test-proxied-https-auth.px
> >> 
> >> Implement a second HTTPS server inside the test itself and do not use
> >> the standard WgetTest.pm class. In these implementations, we do not
> >> actually chdir() to the correct test directory. I've been seeing some
> >> failures in make distcheck, because the file needs-auth.txt sometimes
> >> is left over after the test is run. Currently, I haven't been able to
> >> debug the issue for why the file remains around, but I guess we should
> >> fix the test directory for it first.
> >> 
> >> My Perl is ridiculously horrible. So if someone who knows a bit of
> >> Perl can help, I'd be very grateful! Else, I'll sit down over the
> >> coming weekend and make the changes.
> >> 
> >> --
> >> Thanking You,
> >> Darshit Shah

Attachment: signature.asc
Description: This is a digitally signed message part.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]