Re: [Bug-wget] [PATCH] the libidn problem

[Tim Ruehsen]

On Wednesday 01 July 2015 13:02:43 Ander Juaristi wrote:
> On 07/01/2015 12:57 PM, Tim Ruehsen wrote:
> >> - Removed the call to quote() at idn_encode() since it segfaults with
> >> 0xFC (the same test proposed by the reporters of #45236).
> > 
> > The reason is simply a bug in my code.
> > 
> >        xfree (utf8_encoded);
> >        logprintf (LOG_VERBOSE, _("Invalid UTF-8 sequence: %s\n"),
> >        
> >            quote(utf8_encoded));
> > 
> > Instead it should be
> > 
> >        logprintf (LOG_VERBOSE, _("Invalid UTF-8 sequence: %s\n"),
> >        
> >            quote(utf8_encoded));
> >        
> >        xfree (utf8_encoded);
> 
> I tried putting xfree() after the call to quote(), and it segfaulted too.
> Doesn't happen to you?

Definitely not. If quote() doesn't work, Wget wouldn't work at all.
I just used valgrind without issue:

TESTS_ENVIRONMENT="VALGRIND_TESTS=1" make check

Are you on current master ? (./boostrap, ./configure, make clean make check 
again)

Tim

signature.asc
Description: This is a digitally signed message part.