[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug-wget] HSTS ready

From: Tim Ruehsen
Subject: Re: [Bug-wget] HSTS ready
Date: Thu, 02 Jul 2015 09:38:10 +0200
User-agent: KMail/4.14.2 (Linux/4.0.0-2-amd64; KDE/4.14.2; x86_64; ; )

On Wednesday 01 July 2015 16:47:04 Ander Juaristi wrote:
> Here goes the HSTS engine! Leave your comments, please.
> I must say Tim's feedback was both strict and invaluable. Two good things :D

Thank you. It is a pleasure to work with you and it is a joy to review your 
code. AFAIR, my suggestions did not touch basic functionality, they were just 
hints for straighten some code.

You made a very good job !

One little thing I just stumbled upon... I guess you won't need the new 
function countchars().
  while (match == NO_MATCH &&
      (pos = strchr (k->host, '.')) && pos - k->host > 0 &&
      countchars (k->host, '.') > 1)

IMO, you could write it as
  while (match == NO_MATCH &&
      (pos = strchr (k->host, '.')) && pos - k->host > 0 &&
      strchr (pos + 1, '.'))

Best regards


Attachment: signature.asc
Description: This is a digitally signed message part.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]