Re: [Bug-wget] Metalink support

[Tim Ruehsen]

Hi Hubert,

thanks for all your work on Metalink support !

Just a few minor points I stumbled upon when I tried to apply your patches :-)

- they don't apply smoothly on latest master. Could you rebase your work on 
current master ?
(What I did it is 'git am 00*' with your patches)

- I had to find out that I need libgpgme11-dev package (on Debian here), else 
./boostrap and/or ./configure would not work. Please add this information to 
README.checkout.

- still libmetalink was missing and a 'make check' failed with
../src/libunittest.a(libunittest_a-test.o): In function `all_tests':
/usr/oms/src/wget/src/test.c:51: undefined reference to `test_find_key_value'
/usr/oms/src/wget/src/test.c:52: undefined reference to `test_find_key_values'
/usr/oms/src/wget/src/test.c:53: undefined reference to `test_has_key'
Please add a #ifdef to src/test.c and also mention libmetalink in 
README.checkout.

It seems that libmetalink hasn't been packaged by Debian yet. I'll come back 
when I have libmetalink installed... (I'll find some time at the weekend).

Regards, Tim

On Friday 03 July 2015 00:56:21 Hubert Tarasiuk wrote:
> I have adjusted some comments to reflect the current libmetalink situation.
> 
> Moreover, I added another option: --preferred-location=<location> that
> can be used to give priority to certain Metalink resources based on
> their location.
> 
> These changes are presented in three additional commits (10, 11, 12) for
> easier review (against previous patches). They should be probably
> squashed before merging:
> squash 1,9,10,11 into one
> squash 5,12 into one