Re: [Bug-wget] Metalink support

[Giuseppe Scrivano]

Hubert Tarasiuk <address@hidden> writes:

> W dniu 04.07.2015 o 00:15, Anthony Bryan pisze:
>>>
>>> Of course it works for me, but we are not talking about me :-)
>>>
>>> The main question is: what does the typical wget user expect ?
>>> I would thinks (s)he expects the download of the file described by the
>>> .metalink file. Of course a few users really want to have only the .metalink
>>> file (for testing/inspection). So there should be a possibility to do 
>>> exactly
>>> that (e.g. --keep-metalink).
>>>
>>> Before making any decision/action we should wait for some other voices.
>> 
>> I'm not sure what the typical wget user expects, but here are some examples.
>> 
>> if you keep the current behavior, it might be helpful to print to the
>> user that they've downloaded a metalink, and how to make wget use it.
>> 
>> aria2 (another command line metalink downloader) uses these commands
>> to download the metalink and process it (download the file described
>> by it & do a hash check) by default. you have to specify
>> '--follow-metalink=false' to only download the metalink XML file.
> I like that option.
>
> Also, I am including the amended patches. There was an issue with
> freeing memory when the Metalink parsing failed (I have moved the
> metalink_delete call from outside to inside of the 'else' block in
> main.c:1806).

pushed!

Giuseppe