[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug-wget] [PATCH] rejected-log: Add option to dump URL rejections t

From: Jookia
Subject: Re: [Bug-wget] [PATCH] rejected-log: Add option to dump URL rejections to a log.
Date: Tue, 28 Jul 2015 16:01:45 +1000
User-agent: Mutt/1.5.23+102 (2ca89bed6448) (2014-03-12)

Hey thanks for the reply,

On Mon, Jul 27, 2015 at 05:03:53PM +0200, Giuseppe Scrivano wrote:
> I tried the patch but some tests fail after I apply it, could you verify
> that "make check" passes without problems?  It seems wget exits with the
> wrong return code.

I was unaware there were tests. I've fixed the regression: I forgot to check if
the option was enabled and blindly wrote to a bad file handle. Yikes.

> In addition, could you add a ChangeLog-like format for the commit
> message?  You can check recent commits to see how the style looks like.

Absolutely! I'll also fix some issues in the code style too that I've noticed.

> Would be nice to have a test for the new option.

Yes it would! I've added a basic test but it won't test all permutations of
possible rejection reasons, just the mechanism for the log itself.

I'll hopefully have the patch as another reply to your message. My remaining
issue with it is that the CSV format doesn't have any kind of versioning which
would mean any changes to the columns could perhaps upset scripts.

One solution would be to embed a header naming the columns which would allow
scripts to check if the columns are recognized and in the right order, and if
they're not then handle them by ordering recognized headers in to something they
can use. If this sounds like I good idea I can add this.

> Thanks,
> Giuseppe


reply via email to

[Prev in Thread] Current Thread [Next in Thread]