bug-wget
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug-wget] [PATCH] FTPS support


From: Ander Juaristi Alamos
Subject: Re: [Bug-wget] [PATCH] FTPS support
Date: Thu, 10 Sep 2015 16:05:14 +0200

> Hi Ander,
> 
> during the last test I realized that --recursive won't work with FTPS.

Hi Tim,

If been looking through it and I've seen that the '--recursive' option from FTP 
and the one from FTPS follow different code paths.

The code that triggers that difference is at main.c, line 1832:

        if ((opt.recursive || opt.page_requisites)
              && (url_scheme (*t) != SCHEME_FTP || url_uses_proxy (url_parsed)))
            {
              ...
              /* Turn opt.follow_ftp on in case of recursive FTP retrieval */
              if (url_scheme (*t) == SCHEME_FTP)
                opt.follow_ftp = 1;
              ...
            }

If I replace it to include FTPS also:

        if ((opt.recursive || opt.page_requisites)
              && ((url_scheme (*t) != SCHEME_FTP && url_scheme (*t) != 
SCHEME_FTPS)
                  || url_uses_proxy (url_parsed)))
            {
              ...
              /* Turn opt.follow_ftp on in case of recursive FTP retrieval */
              if (url_scheme (*t) == SCHEME_FTP || url_scheme (*t) == 
SCHEME_FTPS)
                opt.follow_ftp = 1;
              ...
            }

Then they both follow the same path. The rationale behind this is that the 
functionality for FTP should behave exactly the same for FTPS.

However, it hangs when downloading the files... Will look further.

Any thoughts?
 
Regards,

- AJ



reply via email to

[Prev in Thread] Current Thread [Next in Thread]