Re: [Bug-wget] [PATCH] Re: [RFE / project idea]: convert-links for "transparent proxy" mode

[Ander Juaristi]

Hi Gabriel,

Thanks for your helpful comments.

I've corrected the patch.

For me, the most embarrassing thing was having forgotten the commit description 
:D

On 09/24/2015 04:13 PM, Gabriel L. Somlo wrote:
> Hi AJ,
>
> Thanks for implementing this! I tested it, and the functionality
> appears correct.
>
> I've added a more detailed review inline, below.
> > +static char *
> > +convert_basename (const char *p, const struct urlpos *link)
> > +{
> > +  int len = link->size;
> > +  char *url = NULL;
> > +  char *org_basename = NULL, *local_basename = NULL;
> > +  char *result = url;
>
> None of the string variables above really need to be initialized,
> since you're going to assign them unconditionally below regardless.

I always initialize local variables by default. For me it's good practice.

> Consider inverting the test. If basenames are *equal*, return 'url'
> immediately, and save an unnecessary xstrdup() + xfree().
>
> Otherwise, call uri_merge() and xfree(url) before returning the
> result.

Done.

Finally, I also updated the documentation at doc/wget.texi.

> Thanks much,
> --Gabriel


Regards,
- AJ

0001-Added-convert-file-only-option.patch
Description: Text Data