Re: [Bug-wget] Travis-CI updates and minor bug fixes

[Tim Rühsen]

Hi Darshit,

nice to see your Travis-CI patches !

I am not sure, but maybe an older version of valgrind hits you:
http://stackoverflow.com/questions/12708501/valgrind-breaks-with-dirname
(They say memrchr should work with valgrind 3.8+... but maybe just from 3.8.1 
on ?)
I guess a suppression to silence valgrind makes sense.


You have
+before_script:
+    - export CFLAGS="-O2 -Wall -Wextra"

but the script sets CFLAGS on its own... I am not sure how these interfere 
and/or influence 'make check|distcheck'.

Your patches look fine to me, looking forward for the push.

Regards, Tim


Am Samstag, 10. Oktober 2015, 21:50:07 schrieb Darshit Shah:
> I've recently been working on setting up an automated build and test
> of the Wget source on Travis-CI. This threw a couple of issues that
> I've since debugged.
> 
> As of now, there is an automated build and test of Wget on every
> commit pushed to the "travis" branch on my personal repository of Wget
> on Github[1]. I have attached two patches here which came to light due
> to the Travis tests.
> 1. The valgrind suppressions file for SSL tests was not included in
> the MAKE_DIST variable causing distcheck to fail.
> 2. Fix wrong logic in Test-ftp-pasv-no-support.px.
> 
> Also, I've attached a patch for including the .travis.yml file and a
> script for compiling and running tests on the Travis container. If
> someone here has experience setting up tests on Travis, kindly to
> review the patch to see if something can be improved.
> 
> Currently, the tests on Travis fail since the valgrind tests are
> failing. This is interesting because on my Arch Linux machine with
> valgrind 3.11, all the tests pass. But on the Ubuntu Precise container
> with Valgrind 3.8, 6 of the Perl tests fail due to "An unconditional
> jump based on uninitialized values". I can reproduce these on a
> virtual machine running Ubuntu Precise, but am unable to do so on my
> local Arch Linux machine. The log file for the latest run as of this
> email is:
> https://s3.amazonaws.com/archive.travis-ci.org/jobs/84697418/log.txt
> 
> If this looks good, I'd like to set up Travis to run against a new
> commit push to Wget's repository on Savannah and add a couple more
> test cases.
> 
> 
> [1]: https://github.com/darnir/wget